From cb6e42b4f0586666a80353c77ff754dfcc1fd51c Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Feb 26 2019 20:35:24 +0000 Subject: PR#1292: define _sortByKeyFuncNoneGreatest as staticmethod Merges #1292 https://pagure.io/koji/pull-request/1292 Fixes: #1291 https://pagure.io/koji/issue/1291 _sortByKeyFuncNoneGreatest is broken --- diff --git a/hub/kojihub.py b/hub/kojihub.py index 5403306..edf82e8 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -11052,6 +11052,7 @@ class RootExports(object): else: return 1 + @staticmethod def _sortByKeyFuncNoneGreatest(key): """Return a function to sort a list of maps by the given key. None will sort higher than all other values (instead of lower). @@ -11121,7 +11122,7 @@ class RootExports(object): else: reverse = False if filterOpts.get('noneGreatest', True): - results.sort(self._sortByKeyFuncNoneGreatest(order), reverse=reverse) + results.sort(key=self._sortByKeyFuncNoneGreatest(order), reverse=reverse) else: results.sort(key=order, reverse=reverse)