freeipa

#5892 Unused code in LDAPRemoveReverseMember
Closed: Fixed Opened by mbasti.

Closed: Fixed
Reopen Issue

attrs_list is unused variable in LDAPRemoveReverseMember class

        if options.get('all', False):
            attrs_list = ['*'] + self.obj.default_attributes
        else:
            attrs_list = set(self.obj.default_attributes)
            if options.get('no_members', False):
                attrs_list.difference_update(self.obj.attribute_members)
            attrs_list = list(attrs_list)

I'm not sure if this is just forgotten code, or we have hidden bug there

Added in 4ad8055341b9f12c833abdf757755ed95f1b375e, usage removed in 3ba9cc8eb42c22e1a5b205b6933e3110d2cbd36c.
For me it looks like just forgotten code.

It is unused code

master:

  • c56d65b064e1e0410c03cf1206816cad4d8d86cc Removed dead code from LDAP{Remove,Add}ReverseMember

master:

  • 30d054a573e08aedecdc211d50c9dd8ebd2777ea Revert "Removed dead code from LDAP{Remove,Add}ReverseMember"
  • 427bbf6c0d61cf52f14a9f2606143f994340ec83 The LDAP*ReverseMember shouldn't imply --all is always specified

Metadata Update from @mbasti:
- Issue assigned to stlaz
- Issue set to the milestone: FreeIPA 4.4
Metadata
None
None
None
Normal
defect
IPA
1
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.