In FreeIPA 4.4 there are multiple ways to establish an LDAP connection. Connections are also established and re-used in random places.
The refactoring effort focuses on:
master:
Leaving ticket opened, there might be some minor enhancements or fixes. Please close it when refactoring of LDAP connections is done.
9340a1417acf120fed3e9ffbe9d658d3456743a1 removes Directory Manager password from nolog which causes it to appear in ca/kra installation logs.
Nice catch, Standa. I missed this one.
In 9340a1417acf120fed3e9ffbe9d658d3456743a1 I removed the dm_password from no_log as well as the class, so that change in itself was fine. However, when I realized CA can't be installed without dm_password, I re-added it in 7a1c0db989cf59a778676635e160f73ebc610694 without appending it to no_log.
There is a regression with ipa-ca-install on a DL-0 replica:
$ ipa-ca-install /home/frenaud/replica-info-vm-159.abc.idm.lab.eng.brq.redhat.com.gpg Directory Manager (existing master) password: Run connection check to master Connection check OK ipa : CRITICAL CA DS schema check failed. Make sure the PKI service on the remote master is operational. Your system may be partly configured. Run /usr/sbin/ipa-server-install --uninstall to clean up. Unexpected error - see /var/log/ipareplica-ca-install.log for details: DatabaseError: Connect error: Start TLS request accepted.Server willing to negotiate SSL.
The commit 5b81dbfda1e4f0799d4ce87e9987a896af3ff299 seems to be the culprit as it is using (in ipaserver/install/cainstance.py, line 1307)
cacert=config.dir + "/ca.cer"
instead of
cacert=config.dir + "/ca.crt"
Metadata Update from @tkrizek: - Issue assigned to tkrizek - Issue set to the milestone: FreeIPA 4.5