#7729 Bad output on failed client installation rollback
Closed: fixed Opened by rcritten.

Issue

A failed client installation, for example for a bad OTP value, will include a lot of extra, incorrect output on the installation.

Joining realm failed: Incorrect password.

Installation failed. Rolling back changes.
Unconfigured automount client failed: CalledProcessError(Command ['/usr/sbin/ipa-client-automount', '--uninstall', '--debug'] returned non-zero exit status 1: '')
Disabling client Kerberos and LDAP configurations
WARNING: Unable to revert to the pre-installation state ('authconfig' tool has been deprecated in favor of 'authselect'). The default sssd profile will be used instead.
The authconfig arguments would have been: authconfig --disableldap --disablekrb5 --disablesssdauth --disablemkhomedir
An error occurred while removing SSSD's cache.Please remove the cache manually by executing sssctl cache-remove -o.
Redundant SSSD configuration file /etc/sssd/sssd.conf was moved to /etc/sssd/sssd.conf.deleted

Steps to Reproduce

  1. ipa-client-install -U -w bogus

The automount error is generated because check_client_configuration() raises a ScriptError with the wrong return value. It sets nothing which defaults to 1. It should be 2 (CLIENT_NOT_CONFIGURED)

The authconfig error is because the system has not gotten far enough to even try enabling authselect so because there is no value in sysrestore it assumes something went sideways.

Metadata Update from @rcritten:
- Issue assigned to rcritten
- Issue priority set to: normal
- Issue set to the milestone: FreeIPA 4.7.2

PR https://github.com/freeipa/freeipa/pull/2446

master:

  • 235b5bd643947eee4e31c0cfed1729b7d945719c Remove the authselect profile warning if sssd was not configured.
  • e59ee6099f065c2155e3be13025459108daf7900 Fix misleading errors during client install rollback
  • 552777293d7c0741e7f9302088ebccf1ee7ba27e Collect the client and server uninstall logs in tests

ipa-4-7:

  • c64030a357401467d74e77d610d3bc268412220d Remove the authselect profile warning if sssd was not configured.
  • ec5e821f05cbc20517af6c9578e813f1963a9e8c Fix misleading errors during client install rollback
  • db960e32f155412c34807e204add4858090d3e94 Collect the client and server uninstall logs in tests

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata