Today, the new pylint (2.4.0) was released. https://github.com/PyCQA/pylint/blob/pylint-2.4.0/doc/whatsnew/2.4.rst
This exposes many errors at Tox test task:
pylint3 create: /__w/1/s/.tox/pylint3 pylint3 installdeps: ipaclient[csrgen,otptoken_yubikey,ldap], pylint pylint3 installed: asn1crypto==0.24.0,astroid==2.3.0,cffi==1.12.3,cryptography==2.7,decorator==4.4.0,dnspython==1.16.0,gssapi==1.6.1,ipaclient==4.9.0.dev201909241341+git6051fd020,ipalib==4.9.0.dev201909241341+git6051fd020,ipaplatform==4.9.0.dev201909241341+git6051fd020,ipapython==4.9.0.dev201909241341+git6051fd020,isort==4.3.21,Jinja2==2.10.1,lazy-object-proxy==1.4.2,MarkupSafe==1.1.1,mccabe==0.6.1,netaddr==0.7.19,pyasn1==0.4.7,pyasn1-modules==0.2.6,pycparser==2.19,pylint==2.4.0,python-ldap==3.2.0,python-yubico==1.3.3,pyusb==1.0.2,qrcode==6.1,six==1.12.0,typed-ast==1.4.0,wrapt==1.11.2 pylint3 run-test-pre: PYTHONHASHSEED='3240076622' ************* Module ipalib lib/python3.7/site-packages/ipalib/__init__.py:889: [C0415(import-outside-toplevel), _enable_warnings] Import outside toplevel (ctypes)) lib/python3.7/site-packages/ipalib/__init__.py:890: [C0415(import-outside-toplevel), _enable_warnings] Import outside toplevel (warnings)) lib/python3.7/site-packages/ipalib/__init__.py:940: [C0415(import-outside-toplevel), API.packages] Import outside toplevel (ipaserver.plugins)) lib/python3.7/site-packages/ipalib/__init__.py:946: [C0415(import-outside-toplevel), API.packages] Import outside toplevel (ipaclient.remote_plugins)) lib/python3.7/site-packages/ipalib/__init__.py:947: [C0415(import-outside-toplevel), API.packages] Import outside toplevel (ipaclient.plugins)) lib/python3.7/site-packages/ipalib/__init__.py:955: [C0415(import-outside-toplevel), API.packages] Import outside toplevel (ipaserver.install.plugins)) ************* Module ipalib.parameters lib/python3.7/site-packages/ipalib/parameters.py:560: [W0125(using-constant-test), Param.__init__] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:762: [W0125(using-constant-test), Param.normalize] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:765: [W0125(using-constant-test), Param.normalize] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:841: [W0125(using-constant-test), Param.convert] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:873: [W0125(using-constant-test), Param.validate] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:876: [W0125(using-constant-test), Param.validate] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/parameters.py:968: [R1724(no-else-continue), Param.__json__] Unnecessary "elif" after "continue") lib/python3.7/site-packages/ipalib/parameters.py:971: [R1721(unnecessary-comprehension), Param.__json__] Unnecessary use of a comprehension) ************* Module ipalib.plugable lib/python3.7/site-packages/ipalib/plugable.py:455: [W0125(using-constant-test), API.bootstrap] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/plugable.py:479: [W0125(using-constant-test), API.bootstrap] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/plugable.py:511: [W0125(using-constant-test), API.bootstrap] Using a conditional statement with a constant value) lib/python3.7/site-packages/ipalib/plugable.py:655: [W0125(using-constant-test), API.add_package] Using a conditional statement with a constant value) ************* Module ipalib.frontend lib/python3.7/site-packages/ipalib/frontend.py:578: [R1721(unnecessary-comprehension), Command.__attributes_2_entry] Unnecessary use of a comprehension) lib/python3.7/site-packages/ipalib/frontend.py:1070: [R1724(no-else-continue), Command.output_for_cli] Unnecessary "elif" after "continue") lib/python3.7/site-packages/ipalib/frontend.py:1075: [R1724(no-else-continue), Command.output_for_cli] Unnecessary "else" after "continue") lib/python3.7/site-packages/ipalib/frontend.py:1302: [R1721(unnecessary-comprehension), Object.__json__] Unnecessary use of a comprehension) ************* Module ipapython.ipachangeconf lib/python3.7/site-packages/ipapython/ipachangeconf.py:190: [R1721(unnecessary-comprehension), IPAChangeConf.dump] Unnecessary use of a comprehension) ----------------------------------- Your code has been rated at 9.99/10 ERROR: InvocationError for command '/__w/1/s/.tox/pylint3/bin/python -m pylint --rcfile=/__w/1/s/pylintrc --load-plugins pylint_plugins /__w/1/s/.tox/pylint3/lib/python3.7/site-packages/ipaclient /__w/1/s/.tox/pylint3/lib/python3.7/site-packages/ipalib /__w/1/s/.tox/pylint3/lib/python3.7/site-packages/ipapython' (exited with code 28)
I'm looking into this.
master:
ipa-4-8:
Metadata Update from @ftweedal: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
ipa-4-6:
ipa-4-7: