#8363 DNS config upgrade code fails
Closed: fixed by abbra. Opened by abbra.

freeipa 4.8.6 to ipa-4-8 (pre-4.8.7) upgrade fails:

2020-06-09T12:36:31Z INFO [Removing deprecated DNS configuration options]
2020-06-09T12:36:31Z DEBUG No changes made
2020-06-09T12:36:31Z ERROR IPA server upgrade failed: Inspect /var/log/ipaupgrade.log and run command ipa-server-upgrade manually.
2020-06-09T12:36:31Z DEBUG   File "/usr/lib/python3.8/site-packages/ipapython/admintool.py", line 179, in execute
    return_value = self.run()
  File "/usr/lib/python3.8/site-packages/ipaserver/install/ipa_server_upgrade.py", line 54, in run
    server.upgrade()
  File "/usr/lib/python3.8/site-packages/ipaserver/install/server/upgrade.py", line 2409, in upgrade
    upgrade_configuration()
  File "/usr/lib/python3.8/site-packages/ipaserver/install/server/upgrade.py", line 2220, in upgrade_configuration
    named_add_ipa_ext_conf_file(),
  File "/usr/lib/python3.8/site-packages/ipaserver/install/server/upgrade.py", line 602, in named_add_ipa_ext_conf_file
    bindinstance.named_add_ext_conf_file(
  File "/usr/lib/python3.8/site-packages/ipaserver/install/bindinstance.py", line 310, in named_add_ext_conf_file
    ipa_ext_txt = ipautil.template_file(src, t_params)
  File "/usr/lib/python3.8/site-packages/ipapython/ipautil.py", line 321, in template_file
    return template_str(f.read(), vars)
  File "/usr/lib/python3.8/site-packages/ipapython/ipautil.py", line 308, in template_str
    val = string.Template(txt).substitute(vars)
  File "/usr/lib64/python3.8/string.py", line 126, in substitute
    return self.pattern.sub(convert, self.template)
  File "/usr/lib64/python3.8/string.py", line 119, in convert
    return str(mapping[named])
2020-06-09T12:36:31Z DEBUG The ipa-server-upgrade command failed, exception: KeyError: 'NAMED_DNSSEC_VALIDATION'
2020-06-09T12:36:31Z ERROR Unexpected error - see /var/log/ipaupgrade.log for details:
KeyError: 'NAMED_DNSSEC_VALIDATION'
2020-06-09T12:36:31Z ERROR The ipa-server-upgrade command failed. See /var/log/ipaupgrade.log for more information

Metadata Update from @cheimes:
- Issue assigned to cheimes
- Issue priority set to: critical
- Issue set to the milestone: FreeIPA 4.8.7
- Issue tagged with: bug

master:

  • 379b560c75bbd5ba9d73a65b5ddfcf086dab3c48 Fix named.conf update bug NAMED_DNSSEC_VALIDATION
  • cddd07f68a28f1b1c21103e9edd6e31a6e4c3716 Remove named_validate_dnssec update step
  • 996a220900502ed5b6450af14c271e4f344f8cf6 Fix named.conf named_conf_include_re
  • 43dd1e8a65826898ebcf2351cd248b876c625ed1 More upgrade tests
  • f52a15b808aa4d827c1f77f807611d49c9563d03 Overhaul bind upgrade process

ipa-4-8:

  • aa2f93262f187b122cb3e3e0c755e21d98bb95d3 Fix named.conf update bug NAMED_DNSSEC_VALIDATION
  • 6ddaead3d70f0de8aa40a3eef313fa1ff24eb25c More upgrade tests
  • 03abb28afeb3983799a112ba96c2674e24cce81d Remove named_validate_dnssec update step
  • 1d3649ebb720d21ac06b23c947107abe20de2d1e Fix named.conf named_conf_include_re
  • b2c3c040ddb7cf3c509b8221ce25574b8d6774d0 Overhaul bind upgrade process

Metadata Update from @abbra:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata