#9734 crash in ipa-otpd with --client-secret-stdin use
Closed: fixed by frenaud. Opened by abbra.

when client secret is not provided, ipa-otpd still attempts to push a secret to the stdin to oidc_child and crashes in strlen(NULL).

We only need to push the secret if it was specified. We already pass --client-secret-stdin to oidc_child only if that is the case, so it is a regression.


PR: https://github.com/freeipa/freeipa/pull/7659

Metadata Update from @abbra:
- Issue assigned to abbra

Metadata Update from @frenaud:
- Custom field rhbz adjusted to https://issues.redhat.com/browse/RHEL-74465, https://issues.redhat.com/browse/RHEL-74465

master:

  • f12c4ed600e9b35c930d386b37e36064fbf83968 ipa-otpd: do not pass OIDC client secret if there is none to pass
  • 4e43dd7cd30042588a2264fca98b6e6b9d4d25bb Migrate Keycloak tests to JDK 21 and Keycloak 26
  • 92ca7c63322f2a8f496cd6b2faf322e7cbc9b4cf Reintroduce test_idp to gating tests

Metadata Update from @frenaud:
- Custom field rhbz adjusted to https://issues.redhat.com/browse/RHEL-74465, https://issues.redhat.com/browse/RHEL-74466 (was: https://issues.redhat.com/browse/RHEL-74465, https://issues.redhat.com/browse/RHEL-74465)

ipa-4-12:

  • d86db9d2c107c66372f422f1d628624b1a55ad45 ipa-otpd: do not pass OIDC client secret if there is none to pass
  • 431a5804949417257b204125ff0a898b98dd2a90 Migrate Keycloak tests to JDK 21 and Keycloak 26
  • 4ea78404a4202456b33ee58723b590f5b6f2f5aa Reintroduce test_idp to gating tests

ipa-4-11:

  • 2bcab2c115ec96eeadde611d43cadb92a7e85887 ipa-otpd: do not pass OIDC client secret if there is none to pass
  • ba6a24e6c000694a4581f577b5bd92f88571d934 Migrate Keycloak tests to JDK 21 and Keycloak 26
  • 58511c156534349fdfbf19eda7c462a42434d9ec Reintroduce test_idp to gating tests

ipa-4-10:

  • b51874e3e695c65777f6398ceb8386c653182799 ipa-otpd: do not pass OIDC client secret if there is none to pass
  • dedba301cea42b714b67cde38fcdc14c5de3ea82 Migrate Keycloak tests to JDK 21 and Keycloak 26
  • e320106baf25e9e94265fbcc57120f061d42f0cc Reintroduce test_idp to gating tests

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata