pylint37 installed: asn1crypto==0.24.0,astroid==2.0.0.dev3,certifi==2018.4.16,cffi==1.11.5,chardet==3.0.4,cryptography==2.2.2,custodia==0.6.0,dbus-python==1.2.8,decorator==4.3.0,dnspython==1.15.0,dogtag-pki==10.3.5.1,gssapi==1.5.0,idna==2.7,ipaclient==4.6.90rc2.dev201807041405+gitbef8140a7,ipalib==4.6.90rc2.dev201807041405+gitbef8140a7,ipaplatform==4.6.90rc2.dev201807041405+gitbef8140a7,ipapython==4.6.90rc2.dev201807041405+gitbef8140a7,isort==4.3.4,Jinja2==2.10,jwcrypto==0.5.0,lazy-object-proxy==1.3.1,lxml==4.2.3,MarkupSafe==1.0,mccabe==0.6.1,netaddr==0.7.19,netifaces==0.10.7,pyasn1==0.4.3,pyasn1-modules==0.2.2,pycparser==2.18,pylint==2.0.0.dev1,python-augeas==1.0.3,python-dateutil==2.7.3,python-ldap==3.1.0,python-nss==1.0.1,python-yubico==1.3.2,pyusb==1.0.2,qrcode==6.0,requests==2.19.1,six==1.11.0,urllib3==1.23,wrapt==1.10.11 pylint37 runtests: PYTHONHASHSEED='2994310226' pylint37 runtests: commands[0] | .tox/pylint37/bin/python -m pylint --rcfile=pylintrc --load-plugins pylint_plugins --output-format=text ipaserver ipaclient ipalib ipapython ipaplatform ************* Module ipaserver.p11helper ipaserver/p11helper.py:477: [E0705(try-except-raise), loadLibrary] The except handler raises immediately) ipaserver/p11helper.py:890: [R1710(inconsistent-return-statements), P11_Helper.get_slot] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.config ipaserver/plugins/config.py:89: [R1710(inconsistent-return-statements), validate_search_records_limit] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.selinuxusermap ipaserver/plugins/selinuxusermap.py:126: [R1711(useless-return), validate_selinuxuser_inlist] Useless return at end of function or method) ************* Module ipaserver.dcerpc ipaserver/dcerpc.py:1732: [C0330(bad-continuation), ] Wrong hanging indentation. ) | | ^) ipaserver/dcerpc.py:71: [C0414(useless-import-alias), ] Import alias does not rename original package) ipaserver/dcerpc.py:709: [R1710(inconsistent-return-statements), DomainValidator.__search_in_dc] Either all return statements in a function should return an expression, or none of them should.) ipaserver/dcerpc.py:1042: [R1710(inconsistent-return-statements), TrustDomainInstance.generate_ftinfo] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.rpcserver ipaserver/rpcserver.py:192: [R1710(inconsistent-return-statements), read_input] Either all return statements in a function should return an expression, or none of them should.) ipaserver/rpcserver.py:611: [R1710(inconsistent-return-statements), KerberosSession.get_environ_creds] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.role ipaserver/plugins/role.py:250: [C0330(bad-continuation), ] Wrong continued indentation. ), ^ ||) ************* Module ipaserver.plugins.aci ipaserver/plugins/aci.py:411: [R1710(inconsistent-return-statements), validate_permissions] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.permission ipaserver/plugins/permission.py:127: [R1710(inconsistent-return-statements), prevalidate_filter] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/permission.py:144: [R1710(inconsistent-return-statements), validate_type] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/permission.py:791: [R1710(inconsistent-return-statements), permission.preprocess_options] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.realmdomains ipaserver/plugins/realmdomains.py:70: [R1710(inconsistent-return-statements), _domain_name_validator] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.user ipaserver/plugins/user.py:836: [W1662(comprehension-escape), user_find.post_callback] Using a variable that was bound inside a comprehension) ************* Module ipaserver.plugins.privilege ipaserver/plugins/privilege.py:248: [C0330(bad-continuation), ] Wrong continued indentation. ), ^ ||) ************* Module ipaserver.plugins.hbacrule ipaserver/plugins/hbacrule.py:110: [R1710(inconsistent-return-statements), is_all] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.pwpolicy ipaserver/plugins/pwpolicy.py:390: [W1113(keyword-arg-before-vararg), pwpolicy.validate_lifetime] Keyword argument before variable positional arguments list in the definition of validate_lifetime function) ************* Module ipaserver.plugins.dogtag ipaserver/plugins/dogtag.py:342: [R1714(consider-using-in), parse_and_set_boolean_xml] Consider merging these comparisons with "in" to "value in ('true', 'yes')") ipaserver/plugins/dogtag.py:344: [R1714(consider-using-in), parse_and_set_boolean_xml] Consider merging these comparisons with "in" to "value in ('false', 'no')") ipaserver/plugins/dogtag.py:1284: [R1710(inconsistent-return-statements), RestClient.__enter__] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.baseldap ipaserver/plugins/baseldap.py:317: [R1710(inconsistent-return-statements), validate_externalhost] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/baseldap.py:1075: [R1718(consider-using-set-comprehension), BaseLDAPCommand.process_attr_options] Consider using a set comprehension) ipaserver/plugins/baseldap.py:2345: [W0715(raising-format-tuple), BaseLDAPModAttribute._update_attrs] Exception arguments suggest string formatting might be intended) ************* Module ipaserver.plugins.cert ipaserver/plugins/cert.py:1695: [R1716(chained-comparison), cert_find.execute] Simplify chained comparison between the operands) ************* Module ipaserver.plugins.dns ipaserver/plugins/dns.py:402: [R1710(inconsistent-return-statements), _validate_bind_aci] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:426: [R1710(inconsistent-return-statements), _normalize_bind_aci] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:690: [W1113(keyword-arg-before-vararg), DNSRecord.__init__] Keyword argument before variable positional arguments list in the definition of __init__ function) ipaserver/plugins/dns.py:726: [R1710(inconsistent-return-statements), DNSRecord.get_parts_from_kw] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:790: [R1710(inconsistent-return-statements), DNSRecord._rule_validatedns] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:1278: [R1710(inconsistent-return-statements), _validate_naptr_flags] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:1367: [R1710(inconsistent-return-statements), _sig_time_validator] Either all return statements in a function should return an expression, or none of them should.) ipaserver/plugins/dns.py:1455: [R1710(inconsistent-return-statements), _normalize_uri_target] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.krbinstance ipaserver/install/krbinstance.py:57: [R1710(inconsistent-return-statements), get_pkinit_request_ca] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.ipa_server_certinstall ipaserver/install/ipa_server_certinstall.py:215: [R1710(inconsistent-return-statements), ServerCertInstall.replace_key_cert_files] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.adtrust ipaserver/install/adtrust.py:249: [R1710(inconsistent-return-statements), retrieve_potential_adtrust_agents] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.ipa_cacert_manage ipaserver/install/ipa_cacert_manage.py:116: [R1710(inconsistent-return-statements), CACertManage.run] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.service ipaserver/install/service.py:269: [R1710(inconsistent-return-statements), Service.principal] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.installutils ipaserver/install/installutils.py:212: [R1714(consider-using-in), verify_fqdn] Consider merging these comparisons with "in" to "address in ('127.0.0.1', '::1')") ************* Module ipaserver.install.ldapupdate ipaserver/install/ldapupdate.py:91: [R1710(inconsistent-return-statements), safe_output] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.bindinstance ipaserver/install/bindinstance.py:111: [R1710(inconsistent-return-statements), named_conf_get_directive] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.install.cainstance ipaserver/install/cainstance.py:170: [R1710(inconsistent-return-statements), find_substring] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.dnssec.bindmgr ipaserver/dnssec/bindmgr.py:93: [R1714(consider-using-in), BINDMgr.ldap_event] Consider merging these comparisons with "in" to "op in ('add', 'del', 'mod')") ************* Module ipaserver.dnssec.syncrepl ipaserver/dnssec/syncrepl.py:38: [R1710(inconsistent-return-statements), SyncReplConsumer.syncrepl_get_cookie] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.dnssec.odsmgr ipaserver/dnssec/odsmgr.py:110: [R1714(consider-using-in), LDAPZoneListReader.process_ipa_zone] Consider merging these comparisons with "in" to "op in ('add', 'del')") ipaserver/dnssec/odsmgr.py:181: [R1714(consider-using-in), ODSMgr.ldap_event] Consider merging these comparisons with "in" to "op in ('add', 'del')") ************* Module ipaserver.install.server.replicainstall ipaserver/install/server/replicainstall.py:875: [W1306(missing-format-attribute), install_check] Missing format attribute 'host' in format specifier 'env.host') ipaserver/install/server/replicainstall.py:1121: [W1306(missing-format-attribute), promote_check] Missing format attribute 'host' in format specifier 'env.host') ************* Module ipaserver.secrets.client ipaserver/secrets/client.py:89: [R1710(inconsistent-return-statements), CustodiaClient.fetch_key] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaclient.plugins.automember ipaclient/plugins/automember.py:34: [C0330(bad-continuation), ] Wrong continued indentation. ), ^ ||) ************* Module ipaserver.install.server.upgrade ipaserver/install/server/upgrade.py:1201: [R1710(inconsistent-return-statements), find_subject_base] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaclient.plugins.vault ipaclient/plugins/vault.py:673: [E0705(try-except-raise), ModVaultData._do_internal] The except handler raises immediately) ************* Module ipaclient.install.ipadiscovery ipaclient/install/ipadiscovery.py:521: [R1710(inconsistent-return-statements), IPADiscovery.ipadnssearchkrbrealm] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaclient.install.client ipaclient/install/client.py:2078: [R1714(consider-using-in), install_check] Consider merging these comparisons with "in" to "hostname in ('localhost', 'localhost.localdomain')") ************* Module ipalib.aci ipalib/aci.py:116: [R1714(consider-using-in), ACI._parse_target] Consider merging these comparisons with "in" to "operator not in ('=', '!=')") ipalib/aci.py:119: [R1714(consider-using-in), ACI._parse_target] Consider merging these comparisons with "in" to "operator not in ('=', '!=')") ************* Module ipalib.backend ipalib/backend.py:142: [E0705(try-except-raise), Executioner.execute] The except handler raises immediately) ************* Module ipalib.cli ipalib/cli.py:679: [R1716(chained-comparison), textui.select_entry] Simplify chained comparison between the operands) ************* Module ipalib.frontend ipalib/frontend.py:1162: [R1711(useless-return), Command.interactive_prompt_callback] Useless return at end of function or method) ************* Module ipapython.graph ipapython/graph.py:58: [R1714(consider-using-in), Graph.remove_vertex] Consider merging these comparisons with "in" to 'vertex not in (e[0], e[1])') ipapython/graph.py:84: [E1111(assignment-from-no-return), Graph.bfs] Assigning to function call which doesn't return) ************* Module ipalib.parameters ipalib/parameters.py:1999: [R1711(useless-return), AccessTime._rule_required] Useless return at end of function or method) ************* Module ipapython.admintool ipapython/admintool.py:179: [E1111(assignment-from-no-return), AdminTool.execute] Assigning to function call which doesn't return) ************* Module ipalib.rpc ipalib/rpc.py:1074: [E0705(try-except-raise), RPCClient.create_connection] The except handler raises immediately) ************* Module ipapython.install.common ipapython/install/common.py:37: [E1111(assignment-from-no-return), Installable._get_components] Assigning to function call which doesn't return) ************* Module ipapython.install.util ipapython/install/util.py:86: [C0204(bad-mcs-classmethod-argument), InnerClassMeta.__new__] Metaclass class method __new__ should have 'cls' as first argument) ************* Module ipapython.install.core ipapython/install/core.py:275: [R1711(useless-return), Configurable.group] Useless return at end of function or method) ipapython/install/core.py:315: [E0705(try-except-raise), Configurable.__init__] The except handler raises immediately) ipapython/install/core.py:334: [E1111(assignment-from-no-return), Configurable._reset] Assigning to function call which doesn't return) ipapython/install/core.py:341: [R1711(useless-return), Configurable._get_fallback] Useless return at end of function or method) ipapython/install/core.py:357: [R1710(inconsistent-return-statements), Configurable.run] Either all return statements in a function should return an expression, or none of them should.) ipapython/install/core.py:494: [E1128(assignment-from-none), ComponentBase.group] Assigning to function call which only returns None) ************* Module ipapython.ipautil ipapython/ipautil.py:516: [W1509(subprocess-popen-preexec-fn), run] Using preexec_fn keyword which may be unsafe in the presence of threads) ************* Module ipaplatform.base.tasks ipaplatform/base/tasks.py:176: [R1711(useless-return), BaseTaskNamespace.migrate_auth_configuration] Useless return at end of function or method) ************* Module ipaplatform.base.services ipaplatform/base/services.py:168: [R1711(useless-return), PlatformService.reload_or_restart] Useless return at end of function or method) ipaplatform/base/services.py:172: [R1711(useless-return), PlatformService.restart] Useless return at end of function or method) ipaplatform/base/services.py:187: [R1711(useless-return), PlatformService.enable] Useless return at end of function or method) ipaplatform/base/services.py:190: [R1711(useless-return), PlatformService.disable] Useless return at end of function or method) ipaplatform/base/services.py:193: [R1711(useless-return), PlatformService.mask] Useless return at end of function or method) ipaplatform/base/services.py:196: [R1711(useless-return), PlatformService.unmask] Useless return at end of function or method) ipaplatform/base/services.py:199: [R1711(useless-return), PlatformService.install] Useless return at end of function or method) ipaplatform/base/services.py:202: [R1711(useless-return), PlatformService.remove] Useless return at end of function or method) ipaplatform/base/services.py:374: [C0113(unneeded-not), SystemdService.is_installed] Consider changing "not self.service_instance('') in svar" to "self.service_instance('') not in svar") ************* Module ipapython.ipaldap ipapython/ipaldap.py:211: [E0705(try-except-raise), SchemaCache._retrieve_schema_from_server] The except handler raises immediately) ----------------------------------- Your code has been rated at 9.98/10 ERROR: InvocationError: '.tox/pylint37/bin/python -m pylint --rcfile=pylintrc --load-plugins pylint_plugins --output-format=text ipaserver ipaclient ipalib ipapython ipaplatform' ___________________________________ summary ____________________________________ ERROR: pylint37: commands failed