#383 Greenwave refuses to start if the deprecated !FedoraAtomicCi config is used
Closed: Fixed 5 years ago by lucarval. Opened 5 years ago by bowlofeggs.

I discovered today that Greenwave won't start in Bodhi's CI tests due to the use of a deprecated config value.

Deprecation means that the use of the feature is discouraged and will be removed in a future release, but does not mean that it is not supported any longer.

In short, Greenwave should not refuse to start when presented with deprecated settings. If the setting is removed, then it is removed, but the word "deprecated" should not be used and the major version Greenwave should be increased to signal a backwards incompatible change.


Hi @bowlofeggs,
You're right, the word deprecated wasn't properly used, but the version was bumped to 1.0.0 from 0.9.13. Perhaps a better word would be "obsolete" instead.

Ah cool, my bad for not checking on the version bump - I shouldn't have assumed. In that case, I would just change the error message to say "removed" or even just "invalid config".

Metadata Update from @gnaponie:
- Issue assigned to gnaponie

5 years ago

Hello Randy,
sorry for the inconvenience. I hope this sounds better: https://pagure.io/greenwave/pull-request/385

On Wed, 2019-02-06 at 09:01 +0000, Giulia Naponiello wrote:

I hope this sounds better:=20
https://pagure.io/greenwave/pull-request/385=20

Thanks!

It looks like the reported issue has been addressed. Closing this. Feel free to re-open if you disagree.

Metadata Update from @lucarval:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Log in to comment on this ticket.

Metadata