#605 List remote rule file URLs in decision response
Closed: Fixed by lholecek. Opened by lholecek.

It's often unclear from where Greenwave fetched the "gating.yaml" file, or even if it tried to fetch it.

Listing remote rule file URLs in Greenwave's decision response would help developers and users troubleshoot many issues.

There is already an unsatisfied requirement listed in the response if the file cannot be parsed, or it be retrieved and RemoteRule and required=true attribute set.

In other cases there shall be satisfied requirement listed for each RemoteRule.

Example:

"satisfied_requirements": [
  {
    "subject_type": "koji_build",
    "subject_identifier": "tmt-1.1-1.fc34",
    "product_version": "fedora-34",
    "testcase": "fetched-gating-yaml",
    "url": "https://src.fedoraproject.org/rpms/tmt/raw/df1266227d77bf500972bd36785811bc7343d297/f/gating.yaml"
  },
  {
    "subject_type": "koji_build",
    "subject_identifier": "nethack-1.2.3-1.rawhide",
    "product_version": "rawhide",
    "testcase": "not-found-gating-yaml",
    "url": "https://src.fedoraproject.org/rpms/nethack/raw/41c37f252d5ef647320d36ac164dae4d30fcf65c/f/gating.yaml"
  }
]

AC:

  • Add url to unsatisfied requirement items (type is missing-gating-yaml or invalid-gating-yaml).
  • In case such unsatisfied requirement is not listed for a RemoteRule, there should be one satisfied requirement with url.

Commit 94d9f31b fixes this issue

Metadata
Related Pull Requests