#12 An initial implementation of the database models
Closed by ralph. Opened by jcline.
jcline/greenwave db  into  master

Download 12.patch

This is an initial implementation of a set of database models for
policies and rules. It includes an initial Alembic migration for the
database and all the boilerplate for setting up the database.

It does not currently rely on Flask-SQLAlchemy, but it would be simple
to drop it in and it offers some nice additional functionality
(pagination, for example). This is mostly just to gather feedback.

See #10 for the discussion that led to this.

Signed-off-by: Jeremy Cline jeremy@jcline.org

Thanks, Jeremy. This looks like a good start. However, the thing is we are not quite confidence in our design. We're agreed that we will use the YAML configuration file to help release quickly. Once we have more use cases and more confidence in our desgin, we definiltly want to use data models for the polices. See Deferred functionality in the focus doc.

OK - well, this PR has conflicts now as other stuff is changing.

Should we drop it for now and re-open after a while?

The description says @jcline was looking for feedback. @dcallagh, @mjia - any further feedback to give?

I've filed issue #30 for this. I think we could drop it for now and re-open/file a new one when working on the issue.

OK. Thanks guys!

Pull-Request has been closed by ralph

Metadata