greenwave

#146 Bring back FedoraAtomicCI
Merged by ralph. Opened by ralph.
package-specific-rule  into  master

Download 146.patch

It's back.

The motivation here is that I don't think we're going to get the RemoteRule done in time for our deadlines with the OSCI team, and we're going to need a way to whitelist greenwave gating for ~3 packages in the meantime.

Consider merging this:

  • We could rush the RemoteRule work, but merging this lets us continue to take our time on that.
  • We have been carrying this as a patch in Fedora's dist-git for a while. Keeping it there makes releases hard when we cannot automatically rebase the new release on the distro patch. Keeping it in the upstream repo here should relieve some pressure on the release process.
  • This is a known wart that we've been working with for a while. Not much new to learn.

The first one is the AtomicCI pipeline, but this one is? The AllPackages pipeline?

In which case, are we sure the nvr_key is item? (as opposed to original_spec_nvr)

No, this one isn't for the Fedora environment, @pingou. :)

It is for @mvadkert's platformci results.

@mvadkert the message structure is different for that pipeline then?

Note to self - this still needs tests.

2 new commits added

  • Abstract out the PackageSpecificRule to be applicable to both Fedora Atomic CI and OSCI.
  • Create a custom FedoraAtomicCi rule

Rebased to add tests.

@pingou the downstream currently uses the Factory 2.0 CI UMB messages and in the future the FEdora atomic pipeline should also conform to this. Note that OpenQA already leans toward this format and I hope more to join later, so we have 1 format on upstream nad downstream

@dcallagh, @gnaponie - :+1:? :-1:? Thoughts?

Why repos?

But anyway, yes :+1: from me, for all the reasons you listed Ralph. Better than continuing to carry the patch for the Fedora deployment too.

+1

Why repos?

A holdover from when @pingou originally wrote it. It is meant to be the "repo" name for the git repo of the package.

Thanks all!

rebased onto aa7858b1672605e47912853bbb6bef2ac7b55c29

Pull-Request has been merged by ralph
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.