#149 tests: run servers as subprocesses instead of as threads
Merged by dcallagh. Opened by dcallagh.
dcallagh/greenwave fix-tests  into  master

Download 149.patch

This fixes the tests, which were broken since WaiverDB no longer works
with SQLite, it requires Postgres.

This also avoids the issue of WaiverDB wanting Python 3 but ResultsDB
wanting Python 2. And various other edge cases with running all three
applications in the same address space. Plus it makes the tests more
realistic.

This make it easy (or possible at least) to do the functional tests in Jenkinsfile the same way we are doing for WaiverDB. I just need to sort out an image for ResultsDB and come up with an OpenShift template to run all three apps wired up together.

@csomh did you start on something like that?

@dcallagh the test template should work for this.

Oh... I totally missed the fact that we already have an Openshift template! Thanks @csomh I will give it a go tomorrow morning.

+1 in concept. I guess removing that CachedTestingConfig will break the cache tests, hm?

Ah, no, because the greenwave subprocess always uses a cache now :-)

However those tests may still make it difficult to run the functional tests against Openshift. Not sure yet.

rebased onto f410cf54e1d1e7a633a7a7aeae0eba2a303d7f8c

Cool. Let's go for it! :+1:

I didn't finish getting the tests to run against Openshift just yet, but this fixes them for local execution at least, so let's merge this now and do Openshift separately.

Pull-Request has been merged by dcallagh

Metadata