PR#156: Allow patterns in the repo list. -

greenwave

#156 Allow patterns in the repo list.

Merged Apr 18, 2018 by ralph. Opened Apr 12, 2018 by ralph.

fnmatch into master

ralph commented Apr 12, 2018

Fixes #155.

I'm not married to the use of fnmatch over regex or anything else.
It seemed like the simplest thing to reach for.

lholecek commented Apr 17, 2018

Leaving out the square brackets is probably bit more effective (it would create generator instead of allocating list). (I'll need similar code for matching product versions.)

ralph commented Apr 17, 2018

A micro-optimization! Will adjust.

rebased onto 7ecb002f8c71496e4fa547c8f8a523b466bc7c73

Apr 17, 2018

lholecek commented Apr 18, 2018

+1 (...I'll need to resolve merge conflict in #160)

Pull-Request has been merged by ralph

Apr 18, 2018

dcallagh commented Apr 19, 2018

Glob (rather than regexp) seems like a fine choice here.

We should now update the new "how to write a policy" doc to mention that these are interpreted as globs, not just plain string matching.

ralph commented Apr 20, 2018

:+1:, will do that.

Metadata

Assignee

None

Tags

No Tags

greenwave

#156 Allow patterns in the repo list. Merged Apr 18, 2018 by ralph. Opened Apr 12, 2018 by ralph. fnmatch into master

Metadata

#156 Allow patterns in the repo list.

Merged Apr 18, 2018 by ralph. Opened Apr 12, 2018 by ralph.

fnmatch into master