PR#168: Add a retry decorator to wrap frail functions. -

greenwave

#168 Add a retry decorator to wrap frail functions.

Merged Apr 30, 2018 by ralph. Opened Apr 30, 2018 by ralph.

ralph/greenwave retry into master

ralph commented Apr 30, 2018

We're having some DNS issues internally that throw NewConnectionErrors
at us regularly. This is a workaround.

mikeb commented Apr 30, 2018

+1 Looks good!

mikeb commented Apr 30, 2018

Should the retry wrapper log a message (at debug level) that it's waiting/retrying? May be useful to help debug performance and/or stability issues. Not a blocker.

ralph commented Apr 30, 2018

Yes. Will add that and then merge. Thanks!

ralph commented Apr 30, 2018

Oh, actually, it already does that with log.warn. :)

rebased onto 251c008372a3a92f6b1f2a7ce164d064cf21a440

Apr 30, 2018

Pull-Request has been merged by ralph

Apr 30, 2018

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

greenwave

#168 Add a retry decorator to wrap frail functions. Merged Apr 30, 2018 by ralph. Opened Apr 30, 2018 by ralph. ralph/greenwave retry into master

Metadata

#168 Add a retry decorator to wrap frail functions.

Merged Apr 30, 2018 by ralph. Opened Apr 30, 2018 by ralph.

ralph/greenwave retry into master