PR#17: reword summary to be a single line without policy id or item -

greenwave

#17 reword summary to be a single line without policy id or item

Merged Jun 20, 2017 by dcallagh. Opened Jun 19, 2017 by dcallagh.

dcallagh/greenwave summary-one-line into master

dcallagh commented Jun 19, 2017

The summary is supposed to be a short, one-line summary of the overall
answer. The response still includes the structured
"unsatisfied_requirements" key with full details, including policy ids
and items.

mjia commented Jun 19, 2017

I think this should be:
answers.append(policy.check(item, results, waivers))

dcallagh commented Jun 19, 2017

Policy.check() returns a list, so it should indeed be .extend().

mjia commented Jun 19, 2017

oh, right. I was looking at the wrong class, :-)

mjia commented Jun 19, 2017

:thumbsup:

dcallagh commented Jun 20, 2017

I guess we should rename one of those .check() methods to something different to avoid that confusion, since their return types are actually different.

rebased

Jun 20, 2017

dcallagh commented Jun 20, 2017

Rebased to fix conflicts (I didn't change the .check() methods, we can do that in a separate PR).

Pull-Request has been merged by dcallagh

Jun 20, 2017

Metadata

Assignee

None

Tags

No Tags

greenwave

#17 reword summary to be a single line without policy id or item Merged Jun 20, 2017 by dcallagh. Opened Jun 19, 2017 by dcallagh. dcallagh/greenwave summary-one-line into master

Metadata

#17 reword summary to be a single line without policy id or item

Merged Jun 20, 2017 by dcallagh. Opened Jun 19, 2017 by dcallagh.

dcallagh/greenwave summary-one-line into master