#218 Fix showing all results and waivers with verbose flag
Merged by ralph. Opened by lholecek.
lholecek/greenwave fix-verbose-results-and-waivers  into  master

Download 218.patch
no initial comment

Oh yeah, I see this was some subtle breakage I introduced in PR#184.

Does that mean there are no tests covering this case? Do we need some?

Also I wonder... this means now the verbose results will have all of the results for the update plus the results for all the builds in the update, all mixed in together. If Bodhi is going to consume those and display them to users, does that mean Bodhi will need essentially the same logic that Greenwave has (to figure out which results are for the update and which results are for each build in the update)?

Does that mean there are no tests covering this case? Do we need some?

If this is documented and used part of API, then yes. :)

If Bodhi is going to consume those and display them to users, does that mean Bodhi will need essentially the same logic that Greenwave has (to figure out which results are for the update and which results are for each build in the update)?

Looking through the Bodhi source code (devel branch), I cannot find any place they use the verbose flag.

rebased onto 4c9bf0d450805467da590c2a962320139a8d0530

(devel branch)

It is coming in in a few different places - both a javascript query and a server-side one from python: https://github.com/fedora-infra/bodhi/milestone/8

@lholecek, can you add a test for it too?

I've added the tests.

rebased onto c579426a6dd2e49e5c88fe71975a4f264710fb2e

Pull-Request has been merged by ralph

Metadata