The change LGTM, but jenkins didn't like it.

Was it a infra flake, or do the tests need to be changed here too?

I'm fixing the tests ... hmm, it's not very trivial.

yep, +1 but the JJ is failing

When fixing tests, I discovered that decision change message can be send when small detail changes --- like result ID changes in satisfied_requirements/unsatisfied_requirements. This currently breaks test_no_message_for_unchanged_decision test.

Maybe someone listening on UMB will need to keep the result IDs up to date.

What should be the behavior?

BTW, I cannot find anything about messaging in Greenwave docs.

We have this: https://datagrepper.engineering.redhat.com/umb/topics.html#eng-greenwave

We have this: https://datagrepper.engineering.redhat.com/umb/topics.html#eng-greenwave

It says:

Greenwave publishes a message when a new result/waiver causes the decision to change.

Still, does it mean any data in decision changes? E.g. there is new test result that has the same outcome as the last one. But the decision change message could be sent since the result_id in (un)satisfied_requirement changed.

I interpret "decision change" as (for example) all requirements were satisfied before and now not anymore. So I would not consider the change of the result-id a decision change. But... what if, as you said, this information will be useful for someone?

Finally updated!

looking good

Commit e3d53ee0 fixes this pull-request