greenwave

#3 use a global requests session
Merged by dcallagh. Opened by dcallagh.
dcallagh/greenwave global-requests-session  into  master

Download 3.patch

... so that we benefit from connection pooling across requests.

@jcline I think this is what you meant?

Ahh, I was supposed to do that. Why we did not use a global session in Beaker integration tests?

:thumbsup:

A shared session will share cookies (and authentication credentials etc). So you can't use a global session if you need to avoid leaking credentials across different requests, like in the Beaker test suite.

But here there is no authentication and (presumably) no cookies so nothing to leak across different requests. So we can use a single global session.

Okay, that makes sense.

Looks good to me

Pull-Request has been merged by dcallagh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.