greenwave

#343 adding 15 minute timeout to functional tests, removing labeling of master jobs
Merged by gnaponie. Opened by jmolet.
jmolet/greenwave functional-timeout  into  master

Download 343.patch

Throwing a 15 minute timeout around the functional tests in case they hang for whatever reason. This builds resiliency into the jobs a touch more.

Also removes the redundant "master" display name on every job in the master branch. Will revert back to build number (which is also used on the openshift test backend)

+1

That looks ok. But what is the 10 minutes timeout above then? I thought that was already enough (it should be for the pods to get ready). In fact if you have a look at the job history you can see that when it fails it's always around ~10 minutes.

My true question is: if it fails with the first timeout, will it ever get to the second one?
Edited by gnaponie

First 10 minute time out was always there, it was just the limit on how long it'll wait for all the resources to become available in openshift. The 15 minutes is for the actual functional tests running, which has locked up a couple times - and the job will spin forever (you are correct though, the first timeout happens much more often). As it is in this PR, if the first one fails, it'll never get to the 2nd one.

Would you prefer that the whole thing get wrapped in one single 15 minute timeout?

Yeah that's the point... Both are fine, the important thing is that we don't get stuck at the functional tests. So this change would work.
+1

Commit bba49e9a fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.