#351 A new test for RemoteRule and redhat-module
Merged by gnaponie. Opened by gnaponie.
gnaponie/greenwave remoterule-additional-tests  into  master

Download 351.patch
no initial comment

cc. @mvadkert @lucarval

subject_type is missing here. This is why it falls back to koji_build.

If I add subject_type: redhat-module the test is successful.

@gnaponie @lucarval ha! did not know that! so I guess I should edit all the the gating yamls and the RHEL8 developer guide.

So this one should work?

--- !Policy
product_versions:
  - rhel-8
decision_context: osci_compose_gate_modules
subject_type: redhat-module
rules:
  - !PassingTestCaseRule {test_case_name: baseos-ci.redhat-module.tier0.functional}

@mvadkert, that looks right to me

That's right. Also the documentation [1] should be updated since the subject_type can now be set to other values then koji_build.

[1] docs/package-specific-policies.rst

Great work team!
I'll change this PR so we have some more tests... and submit a new one with the updated doc, so we won't have this confusion anymore.

rebased onto 74ff7dc43c8163c660a0b2d3e6da79fdb6f8ede0

rebased onto bcbad9f06e8191b618e3b1c440d268db177e876b

Rebased.

looks good :)

Commit d40ebd1c fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie

Metadata