greenwave

#359 Let's drop Python2 resultsdb functional tests
Merged by lucarval. Opened by gnaponie.
gnaponie/greenwave drop-python2  into  master

Download 359.patch

Let's drop Python2 when creating a fake server instance of ResultsDB
in the functional tests.

It would be nice to quickly note why drop python2.

...because the functional tests don't work for me in python2 :(
...do we need a reason why we should drop python2? :)

Anyhow the error I got was:
from .util.queue import LifoQueue
ImportError: No module named queue

@gnaponie, it's always useful to now the reason behind a change. Sure dropping python2 is something every python project strives for, but there are usually reasons preventing it.

Even something minor such as the functional tests no longer in python2 is sufficient.

:+1:

+1 If it is not needed.

Pull-Request has been merged by lucarval
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.