#364 Add some logs to the API
Merged by gnaponie. Opened by gnaponie.
gnaponie/greenwave some-logs-in-the-api  into  master

Download 364.patch

This is needed for some more debugging. Let's start with something
basic... and then let's see if we need something more.

:+1: LGTM

I wonder if there's something at a lower level that can be configured to just log all the exceptions.

@lucarval, yeah I was thinking about that too. I wouldn't like much a massive try (at the beginning) except (at the end) to log everything. I'm sure there's a more clever way.

I thought that responses are already logged.

Could you use new error handler in greenwave/app_factory.py? Something like app.register_error_handler(BadRequest, log_bad_request).

I thought that responses are already logged.

@lholecek I though that too... and guess what? They are not :D

@lholecek you see the response only if you directly call the api, but it doesn't get in the logs... Maybe we could try something like you said.

At the moment I'm very interested in just seeing if we get the request and the data...

@lholecek It looks like we already do that.
https://pagure.io/greenwave/blob/master/f/greenwave/app_factory.py#_53
And BadRequest is inside default_exceptions...

Pull-Request has been merged by gnaponie

Metadata