greenwave

#377 Return a deprecation error when a user tries to use !PackageSpecificBuild or !FedoraAtomicCi
Merged by gnaponie. Opened by mprahl.
deprecation-error  into  master

Download 377.patch

Also return a warning to the user when they use the blacklist.

rebased onto b99c333c9d323f8538e25614ff5f85bdbefaf988

The subject line of the commit should be 50 chars max... At least that's if we want to follow the Factory's best practices.

Can we put a test also for blacklist? We deprecated also that one.

safe_yaml submodule shouldn't be aware of any such specific tags. It adds indirect dependency policies.

rebased onto 675bb2582aa4134e3dc64809807b72011730f521

@lholecek addressed. Thank you for the review.

2 new commits added

  • Add a deprecation warning for the use of the "blacklist" key
  • Return a deprecation error when a user tries to use !PackageSpecificBuild or !FedoraAtomicCi

+1

 
blacklist_set = any(policy.blacklist for policy in policies)

Would it be possible to raise an exception in those classes instead?

The classes don't exist anymore. I could add them back and have them raise exceptions, but I think this works.

As I mentioned before: safe_yaml shouldn't know about policies.

I also don't like the comparing exception message - that can easily break with different version of yaml library.

As I mentioned before: safe_yaml shouldn't know about policies.
I also don't like the comparing exception message - that can easily break with different version of yaml library.

Okay, so you think reintroduce those classes and have them raise an exception in __init__ then? What exception did you have in mind?

Okay, so you think reintroduce those classes and have them raise an exception in init then? What exception did you have in mind?

Yes. I think you can still use SafeYAMLError if that works.

rebased onto 77b3cfffe03c8be483f0104fb94ed39124142db8

@lholecek could you please review again?

+1 Nice, it's much cleaner now.

rebased onto 570a593034fea2d837ac9e4e4ce5f1e2b9b8ccd7

rebased onto e4fd2bd7863002081074e52eb32b0b49157a008b

+1

rebased onto eef8726bd6c8b2d0b7f7ee355132f0aec6a39826

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.