greenwave

#387 Switch to fedora-29 in the Jenkinsfile
Merged by gnaponie. Opened by gnaponie.
gnaponie/greenwave fedora-29-Jenkins  into  master

Download 387.patch
no initial comment

I think the version should match the one in Dockerfile, right?

rebased onto 5c0234d8e6a701f9b18e375023e26df699cf1ed7

Mmmm I think you are right. Rebased. I guess it's fine now.

+1 ...and Vagrantfile maybe. Nothing can go wrong with sed -i s/28/29/g *file :)

Eheh I wouldn't dare... mmm I guess that's the line that would be needed to be changed?
https://pagure.io/greenwave/blob/master/f/Vagrantfile#_53

Eheh I wouldn't dare... mmm I guess that's the line that would be needed to be changed?
https://pagure.io/greenwave/blob/master/f/Vagrantfile#_53

I think so but I don't use Vagrant and I didn't test that.

I can test the Vagrant change. I'll report back later.

This should do it:

--- a/Vagrantfile
+++ b/Vagrantfile
@@ -50,7 +50,7 @@ $make_devenv = <<DEVENV
 DEVENV
 Vagrant.configure("2") do |config|
-  config.vm.box = "fedora/28-cloud-base"
+  config.vm.box = "fedora/29-cloud-base"
   config.vm.synced_folder "./", "/opt/greenwave"
   # Disable the default share
   config.vm.synced_folder ".", "/vagrant", disabled: true
@@ -59,7 +59,7 @@ Vagrant.configure("2") do |config|
   config.vm.provision "shell", inline: $make_devenv, privileged: false
   config.vm.provider "libvirt" do |v, override|
     # If libvirt is being used, use sshfs for bidirectional folder syncing
-    override.vm.synced_folder "./", "/opt/greenwave", type: "sshfs", sshfs_opts_append: "-o nonempty"
+    override.vm.synced_folder "./", "/opt/greenwave", type: "sshfs"
     v.memory = 1024
   end
   config.vm.provider "virtualbox" do |v|

rebased onto e06d174155e199cefdefd6f3edbbb4116e39591a

Looks great. Thanks, Matt. I've rebased with your suggestion.

:thumbsup:

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.