Signed-off-by: Lukas Holecek hluk@email.cz
Instead of removing the old version, I would add another version, like we have "running the tests with vagrant", I would put something like "running greenwave with the virtualenv". And leave both sessions (with and without virtualenv)
I removed the old instructions because, apart from the fact that installing packages on dev machine is not very convenient, it's yet another place to list the required packages (it's also in Jenkinsfile, Dockerfile and Vagrantfile).
Jenkinsfile
Dockerfile
Vagrantfile
Not sure if Vagrant is the way to go either. Ideally, we use the Dockerfile because it's used to generate the image for prod - but have a way to mount the dev dirs in container (docker-compose up perhaps).
docker-compose up
Can we make this use a pure virtual environment? Is there anything in the system outside of requirements.txt that needs to be available?
Also, why is this not doing a pip install of requirements.txt? And only dev-requirements.txt?
Can we make this use a pure virtual environment?
Unfortunately, using pure venv would still require some packages installed on system (build dependencies for pip) and pip install takes a long time. :'(
pip install
Oops, I expected dev-requirements.txt contains -r requirements.txt. I think it should -- at least I expect it to install everything for development.
dev-requirements.txt
-r requirements.txt
I would really like to use the existing Dockerfile instead of venv but there need to be a nice way to mount/sync devel directory with the container. I'd like to try podman pod commands later.
podman pod
rebased onto ae412ddb8f7d57d50ce0968e08a4bad09af6f95d
rebased onto 967073b766d7f31779b3ad63f652b28f497465a2
I don't really have an opinion on this, but it looks fine to me.
I kinda like how it is right now, because I use resultsdb's virtualenv since I always run the functional tests, but that's my working environment. I would like to keep both version in the doc. The PR look fine anyhow.
I don't like keeping the list of dependencies up-to-date in the doc. I could mention that, instead of using virtualenv, you can install the dependencies listed in the Dockerfile.
@gnaponie Would that be OK?
@lholecek yeah that sounds good to me. Let's go with this solution and let's merge this PR.
rebased onto f032cfe534c46776bf05eaaa44d50529c5a5e221
@gnaponie Updated.
+1 let's merge it
Pull-Request has been merged by gnaponie
Signed-off-by: Lukas Holecek hluk@email.cz