PR#401: Return warning if there is no parent policy for a remote rule policy -

greenwave

#401 Return warning if there is no parent policy for a remote rule policy

Merged Mar 18, 2019 by gnaponie. Opened Mar 15, 2019 by yashn.

warn_missing_decision_context into master

yashn commented Mar 15, 2019

Users mistakenly configure a parent policy with a decision_context and
a gating.yaml file with another decision_context. This can cause unnecessary
delays for the user. In order to avoid this, add a check in the validate_gating_yaml
endpoint to print a warning message notifying the user about it.

yashn commented Mar 15, 2019

@gnaponie can you PTAL?

gnaponie commented Mar 18, 2019

Can we put a message a bit more verbose?
Something that explains what to do next... Something like:
Greenwave could not find a parent policy for following policies with decision_context [...]. Please change your policy so that it will match a decision context in the parent policies.

gnaponie commented Mar 18, 2019

+1 the PR looks fine.
I would just change that tiny thing and then it looks fine to me.

rebased onto 3c9642c90f8865fadac0e1364c8a23a37d94b3e2

Mar 18, 2019

yashn commented Mar 18, 2019

Made the change. Thanks @gnaponie!

gnaponie commented Mar 18, 2019

Thanks Yash.

rebased onto f3cb6cbd5d3872a36ad4a510320575fbb1796094

Mar 18, 2019

Pull-Request has been merged by gnaponie

Mar 18, 2019

Metadata

Assignee

None

Tags

No Tags

greenwave

#401 Return warning if there is no parent policy for a remote rule policy Merged Mar 18, 2019 by gnaponie. Opened Mar 15, 2019 by yashn. warn_missing_decision_context into master

Metadata

#401 Return warning if there is no parent policy for a remote rule policy

Merged Mar 18, 2019 by gnaponie. Opened Mar 15, 2019 by yashn.

warn_missing_decision_context into master