greenwave

#43 return errors in JSON
Merged by mjia. Opened by mjia.
mjia/greenwave issue32  into  master

Download 43.patch

This is aimed to address https://pagure.io/greenwave/issue/32 and https://pagure.io/greenwave/issue/38.

For PEP-8, I suggest one more space here.

It would be good to document the parameter and its type, as well as the type of the response.

I don't see a general copyright claim in the Greenwave repo - I suggest adding a copyright header here.

LGTM!

Would be good to add log.traceback("Returning 500 to user.") which will help with debugging the app in production if it ever goes haywire. log.traceback should print the whole exception. Nice to have.

I'd really like to see the traceback logging added. Otherwise, :+1:.

Yeah, this would be a separate PR.

rebased

Rebased to address the comments.

:+1:

Pull-Request has been merged by mjia
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.