Signed-off-by: gnaponie gnaponie@redhat.com
:thumbsup:
Pull-Request has been merged by mprahl
But the request itself is not wrong, i.e. no reason to return HTTP 400. It'll be hard to tell if the YAML or the request is invalid.
@lholecek and I discussed that over IRC. As discussed internally: if we'll ever bump the api version we're going to change this status code in the new version.
@gnaponie in my opinion you don't need to bump the API version to change the status code if it was set as a mistake. I think it can be treated as a bug and called out in the release notes.
@mprahl this might be an idea. @lucarval are you ok if we do that?
in my opinion you don't need to bump the API version to change the status code if it was set as a mistake. I think it can be treated as a bug and called out in the release notes.
That change would break rpkg which already checks HTTP 400 to indicate errors in gating.yaml.
gating.yaml
Good point, @lholecek. In case we change the status code we should include this rpkg change in the things to do.
Signed-off-by: gnaponie gnaponie@redhat.com