Signed-off-by: gnaponie gnaponie@redhat.com
# pylint: disable=import-error
I'm seeing the same issue, but shouldn't it be imported without an issue? Following doesn't give any errors.
python3 -c 'from requests.packages.urllib3.util.retry import Retry'
This won't work because it doesn't mock the resultdb/waiverdb.
Maybe better to move mocked.return_value = [] from above here.
mocked.return_value = []
mock_results.return_value = [] mock_waivers.return_value = []
Or maybe use decorators like:
@patch('greenwave.resources.ResultsRetriever.retrieve', return_value=[])
(BTW, I thought pylint skips tests.)
pylint: disable=import-error I'm seeing the same issue, but shouldn't it be imported without an issue? Following doesn't give any errors. python3 -c 'from requests.packages.urllib3.util.retry import Retry'
I'm seeing the same issue, but shouldn't it be imported without an issue? Following doesn't give any errors. python3 -c 'from requests.packages.urllib3.util.retry import Retry'
I know! I tried that too and it doesn't give me any errors. Maybe pylint bug? I thought just to disable it.
Yeah it's a bit annoying.
rebased onto 3e30d1a1d4d5be01629e0645e05bae19743b9d38
@lholecek could you please check again?
Can you replace the E* and W* pylint codes with the short identifiers?
E*
W*
1 new commit added
Replace pylint codes with verbal short identifiers
Done
Doesn't pylint or flake8 complain about no space after #?
#
not if it is for pylint... don't ask me why :D
+1
Commit 26ef3db6 fixes this pull-request
Pull-Request has been merged by gnaponie
Signed-off-by: gnaponie gnaponie@redhat.com