greenwave

#480 Fix exception if a Brew build task_id is None
Closed by lholecek. Opened by lholecek.
lholecek/greenwave fix-exception-on-none-brew-task-id  into  master

Download 480.patch

Avoid following XMLRPC exception.

TypeError: cannot marshal None unless allow_none is enabled

Signed-off-by: Lukas Holecek hluk@email.cz

rebased onto 6eac8c1e3aaa7203d049cf67c377a071370a2170

Looks good.

rebased onto 1ff2ffdf30eb7305450d1cbf16f7db585c73e0db

I did some small code adjustments (oh, my perfectionist quirk).

Any idea why the task_id is None? Did this change recently? (Maybe it's a Brew bug.) I know there was some outage and some recent maintenance of Brew.

:) the new code looks fine too.
I frankly don't know. It seems strange to me. But yeah, I would say a bug or some outage. It doesn't seem like the expected behavior.

Ah, actually, it looks like some change. The task ID for containers is stored in 'extra' dict under 'container_koji_task_id' field. :/

We should use brew_task_id from the message when it's available.

See #481.

Pull-Request has been closed by lholecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.