#504 WIP: Containerize Greenwave Jenkins job
Closed by gnaponie. Opened by gnaponie.
gnaponie/greenwave containerize-greenwave-jj  into  master

Download 504.patch

So that we can move it to rad-jenkins instance and increase the
reliability.

JIRA: FACTORY-5029

Signed-off-by: Giulia Naponiello gnaponie@redhat.com

@csomh @lholecek PTAL

No newline at end of file

Having one package per line could make future diffs easier to read.

Nitpick: creating this as jenkins/Dockerfile would be nicer.

Run dnf -y clean all after these, to avoid baking the dnf cache into the image.

&& dnf -y clean all

  • node should be in the podTemplate closure.
  • node should use the pod label
  • podTemplate need should select cloud: 'psi'
podTemplate(
  label: 'greenwave-jenkins-job',
  cloud: 'psi',
  containers: [...]
){
   node('greenwave-jenkins-job') {
   ...
   }
}

... And maybe also other changes: for example building the container image should happen in some other way.

Let's have a discussion tomorrow to walk through this Jenkinsfile and see what and how it should be adapted :)

No newline at end of file

That's what happens when you don't use vim...

rebased onto 84d130803a805af84e7256a2f3645f078748b038

@csomh I've applied your suggestions.
I've also adjusted the indentation.. now it seems like a big change, but it's not.

Pull-Request has been closed by gnaponie

Metadata