I think we could release 1.4.2 too. Does this new release includes some non-backward compatible change?
Not that I'm aware of...

Besides that minor comment, it looks good. +1
@lholecek can you also review?

What does it mean? Was it really broken?

I think we could release 1.4.2 too. Does this new release includes some non-backward compatible change?
Not that I'm aware of...

It's not mentioned there, but what's about timeout change in playbooks?

It's not mentioned there, but what's about timeout change in playbooks?

I think 1.4.2 is enough for that too.

I think we could release 1.4.2 too. Does this new release includes some non-backward compatible change?
Not that I'm aware of...

In semver, backward incompatible change would require major version number bump. Minor version is increased if there are new features -- not sure if not having duplicate entries in requirements is considered new feature or bugfix.

Anyway, I'm OK with having either 1.5.0 or 1.4.2 as a new release.

It's not mentioned there, but what's about timeout change in playbooks?

A parameter change in playbooks are irrelevant to what the release contains.

Made it 1.4.2

What does it mean? Was it really broken?

Hey Valerij, could you address this comment too?
Maybe add some more detailed information about what exactly the change did?

• Fixed koji_build and brew-build subject types.

What does this mean? This is very vague and I don't remember having any such issues.

What does this mean? This is very vague and I don't remember having any such issues.

commit 2545248c4a7b836c90da2814b00de645c38ce362
Author: Lukas Holecek <hluk@email.cz>
Date:   Thu Nov 21 12:20:27 2019 +0100
    Fix installing subject types
    Installing subject types to "/etc/greenwave" breaks existing OpenShift
    templates which remount the configuration directory with custom files.
    This instead installs the files in Python module under
    "conf/subject_types" directory.
    The path to this directory can still be overridden with
    `SUBJECT_TYPES_DIR` option.
    JIRA: FACTORY-5574
    Signed-off-by: Lukas Holecek <hluk@email.cz>

Maybe you can describe it better, as long as you know what you have done there.

Maybe you can describe it better, as long as you know what you have done there.

Remove it. It's not an issue related to previous version; it was broken after last release.

Remove it. It's not an issue related to previous version; it was broken after last release.

Done

Rebased and updated

+1