#544 Simplify remote rules configuration
Closed by lholecek. Opened by lholecek.
lholecek/greenwave simplify-remote-rules-configuration  into  master

Download 544.patch

rebased onto 36463fe0443ee73cab09ffcb3a615e18f5c24936

This is not needed as it won't be used

Won't be used

And have you tried it if it will be work with side tags without git archive?

Won't be used

Ah, good point. The current_app shouldn't be used here - it should use base_url. Fixed.

rebased onto 9c452426a9aeb38658da885cedb224ebde45fbce

And have you tried it if it will be work with side tags without git archive?

Yes, gitlab provides raw links (similar to dist-git) - tested on the README file in the side-tags repo.

This line is not needed at all. Remove it

This line is not needed at all. Remove it

OK, so there was a code in app_factory.py that replaced the {DIST_GIT_BASE_URL} - I've just removed it.

Pull-Request has been closed by lholecek

After a chat with @vmaljulin, he will do some changes now, and let's remove git-archive completely later.

Metadata