#648 Add support for valid_since and valid_until to PassingTestCaseRule
Merged by lholecek. Opened by lholecek.
lholecek/greenwave rule-valid-since-until  into  master

Download 648.patch

What a cool feature! +1

Could we use just strptime without adding additional dependency?

Could we use just strptime without adding additional dependency?

Or for this particular format datetime.date.fromisoformat(string) will be completely enough.

Could we use just strptime without adding additional dependency?

Or for this particular format datetime.date.fromisoformat(string) will be completely enough.

The problem is that I'm unsure what the date/time format is in Koji/Brew (docs says just creation_time: time the build was created (text)) so I need dateutil anyway.

The dateutil package is pretty ubiquitous so it should not be a problem to install it.

@vmaljulin Do you think it's good to merge?

rebased onto 59879ca974e7e9dc6611481185e125e475cfddca

I resolved conflict with previous commit ("Optimize cache usage").

@vmaljulin Can you please review?

Pull-Request has been merged by lholecek

Metadata