#70 add sanity checks when loading the polices
Merged by ralph. Opened by mjia.
mjia/greenwave issue60  into  master

Download 70.patch
no initial comment

rebased

:+1:

Could we cover this with unit tests, perhaps? By feeding in some bad YAML?

Good idea, I've added the unit tests.

rebased

If you use the pytest tmpdir fixture, it will clean up for you (and does the other neat stuff like keeping old ones with rotation).

https://docs.pytest.org/en/latest/tmpdir.html

Thanks, completely forgot that we have this built in py.test. I've updated the patch.

rebased

:+1: very nice

:+1: here too!

Pull-Request has been merged by ralph

Metadata