#91 WIP: expand PassingTestCaseRule to accept blacklist
Closed by mjia. Opened by mjia.
mjia/greenwave blacklist  into  master

Download 91.patch

This is to address #68.

rebased onto 12bbc9bf7f36e94ce2a6d965124157080c5fd1ed

rebased onto c0c98f40489fe1db66a0dd99af696e77e861eef3

rebased onto d21ea3d3d8d5d0adfb082b63221b539a13044b44

Looks like an okay approach to me. :+1: as it goes.

I guess the alternative would have been to put the blacklist on the policy level... and then split our policies so that we have two policies for the same decision context. One for the global checks, and a separate one just for the blacklisted-limited check.

Yeah, putting the blacklist onto the policy level would work too. @dcallagh, could you please reivew this one when you get a chance?

This is a package black list, right? As in, we want to exclude certain packages from certain policies/rules.

So isn't this just another case where we want per-package policies? #75

RIght. This is just a temporary solution in the short term until we can get #75 resolved.

Okay. Seems like it would be cleaner to put the blacklist at the policy level. Since that is probably what we will end up with for #75 (in one form or another).

rebased onto 56d5006e5ae16319bff0332f77e25c05e59fe5c0

Hmm, actually this PR should go to the pre-release-2017-10-04 branch. I will drop this one and make a new one.

Pull-Request has been closed by mjia

Metadata