ipsilon

#121 Retain transaction ID through 401 pages
Merged by merlinthp. Opened by merlinthp.
merlinthp/ipsilon tid  into  master

Download 121.patch

If we get a 401 during a transaction (i.e. failing authentication),
ipsilon shows the 401 error page, which has a link back to the login
page. Clicking this link causes a new transaction to be created,
losing any in-progress service provider authentication, and not
redirecting back to the SP after a successful transaction.

If we hit the 401 page and there's a current transaction, add the
transaction ID to the link back to the login page, so the current
transaction is preserved.

Signed-off-by: Howard Johnson merlin@merlinthp.org

This function will throw a 401 of itself if there is no transaction or if it has expired, which will get us in a loop.

rebased

You're no fun ;)

Fixed.

Looks good to me, thanks!

As discussed on IRC: after testing further, I think you will want "{% if tid %}", since if there is no tid value provided, "tid is not none" does evaluate to True.

rebased

Commit ec5ed542 fixes this pull-request

Pull-Request has been merged by merlin@merlinthp.org
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.