PR#38: Support old OSes like RHEL 6 (python 2.6, httpd 2.2) -

ipsilon

#38 Support old OSes like RHEL 6 (python 2.6, httpd 2.2)

Closed Jul 12, 2016 by puiterwijk. Opened Sep 26, 2015 by merlinthp.

merlinthp/ipsilon rhel6 into master

no initial comment

puiterwijk commented Oct 1, 2015

Why the pipe to /dev/null?

merlinthp commented Oct 6, 2015

I tried to work out if there was a way to only match /usr/share/doc/sssd or /usr/share/doc/sssd- but my bash glob fu isn't up to it. On a versioned docdir OS (like RHEL 6 and 7) this will show the contents of the doc dir for every installed sssd subpackage, which is typically something like 10 packages. The pipe to /dev/null just reduces the spam a bit. I'm not that fussed about keeping the pipe, the * is the important bit.

merlinthp commented Oct 6, 2015

The more I look at this, the less happy I am. I think I was in a mentality of downstream patching, so trying to minimise the number of LoC I was changing. It seems a bit silly to raise the CalledProcessError just to catch it on the next line.

puiterwijk commented Oct 10, 2015

How about switching the call from ls /usr/... to file /usr/...?

puiterwijk commented Dec 1, 2015

Do you want to fix this, or would you like someone else to pick up this PR?

pingou commented Apr 27, 2016

Looks like all the comments got addressed, no?

puiterwijk commented Apr 27, 2016

This PR was WIP, and doesn't work yet.
I have a reworked patch set in my el6-support branch, but I need to work with merlinthp on finishing that up.

rebased

Jul 11, 2016

merlinthp commented Jul 11, 2016

Patrick has taken care of all the fixes needed in master, except for the check_output call in the ipa helper code.