Run the code style checking script for Perl aginst org/mozilla/jss/test/all.pl poor code style. I ran perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl 1> ../all_pl_check.log 2>&1
Results of the check <img alt="check_all.txt" src="/jss/issue/raw/files/585c10ee0d7bacd6a7ac756a5d914b4ade191497b347a965fd8c397c8b4afc05-check_all.txt" />
Yep, i'm aware that this is an issue; I haven't yet gotten around to fixing it, hence why it isn't in our test cases yet. :)
Thanks for reporting it!
Metadata Update from @cipherboy: - Custom field component adjusted to None - Custom field feature adjusted to None - Custom field origin adjusted to None - Custom field proposedmilestone adjusted to None - Custom field proposedpriority adjusted to None - Custom field reviewer adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None
Metadata Update from @cipherboy: - Issue assigned to cipherboy
Patch to clean up the code
<img alt="cleanupTestScript.pl" src="/jss/issue/raw/files/aafd4c928b22b66c3bbd1efe9f04ce5173284ae980707d54dcc634b4efe45ad8-cleanupTestScript.pl" />
After applying reran the check $ perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl and got org/mozilla/jss/tests/all.pl syntax OK
In the patch this change is not needed -createpkcs11_cfg; +createpkcs11_cfg();
Metadata Update from @cipherboy: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
This was addressed in jss pr#31. It went into upstream master in e29dd75e.
Login to comment on this ticket.