#61 Docker set up for development environment
Closed by gabrielsclimaco. Opened by gabrielsclimaco.
kiskadeemes/kiskadee enviroment-with-docker  into  master

Download 61.patch

What this PR do:

  • Add a Dockerfile to build an image for kiskadee development environment
  • Add a shell script to run the built image
  • Update README.md with a "how to" to use de docker

What issues does this PR closes:
#59 Docker set up for development environment

rebased

2 new commits added

  • Fix typo on readme
  • Update README due to removing docker environment shell script
gabrielsclimaco commented

@athoscr I closed the other PR so it could have master as the target branch. I removed the shell script file and updated the README having that in mind. I agree that a Makefile would be great but I don't know how to do that, I suggest opening an issue for that. I already rebased the branch, so if it's not updated with master when you review is due to new commits, so just let me know.

Hi Gabriel, thanks for that!

You need to update your fork's master branch (it's not up to date).

I created a new Makefile in the root of the project after our last interaction, check that out to see how we are creating the containers for the static analyzers and just create a new target to create the development container and another one to run it! If you need help with that, let me know and we can do that together.

gabrielsclimaco commented

The HEAD commit in both branches is 91565a2.

I'll try to make docker run with the existing Makefile and I'll let you know if I have trouble.

The HEAD commit in both branches is 91565a2.

Yet, This commit is not in the source branch [1]. You need to rebase it again

I'll try to make docker run with the existing Makefile and I'll let you know if I have trouble.

OK, let me know

[1] https://pagure.io/fork/kiskadeemes/kiskadee/commits/enviroment-with-docker

gabrielsclimaco commented
Yet, This commit is not in the source branch [1]. You need to rebase it again

After checking that out, I believe the source branch somehow have duplicated commits. I'll create a new branch and cherrypick only my own commits.

Pull-Request has been closed by gabrielsclimaco

Metadata