PR#29: koji-ssl-admin: pkcs12 password must be bytes - koji-tools

koji-tools

#29 koji-ssl-admin: pkcs12 password must be bytes

Merged 5 years ago by tkopecek. Opened 5 years ago by ktdreyer.

ktdreyer/koji-tools ssl-admin-password-bytes into master

koji-ssl-admin: pkcs12 password must be bytes

Ken Dreyer • 5 years ago

a9c6459

src/bin/koji-ssl-admin

file modified

+1 -1

		`@@ -344,7 +344,7 @@`
		`with open(pkcs12_path, 'rb') as f:`
		`if pkcs12:`
		`backend = default_backend()`
		`- pkcs12.load_key_and_certificates(f.read(), 'koji', backend)`
		`+ pkcs12.load_key_and_certificates(f.read(), b'koji', backend)`


		`def server_csr(args):`

ktdreyer commented 5 years ago

In the latest python-cryptography releases, the openssl backend's load_key_and_certificates_from_pkcs12() method expect a bytes object. The cryptography library raises:

  TypeError: password must be bytes-like

Pass in the "koji" password as a bytestring.

tkopecek commented 5 years ago

Is it ok with py2 version? Or should we use six.b('koji') instead?

ktdreyer commented 5 years ago

This particular tool is py3 only, #!/usr/bin/python3

tkopecek commented 5 years ago

Commit e437953 fixes this pull-request

Pull-Request has been merged by tkopecek

5 years ago

Pull-Request has been merged by tkopecek

5 years ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+1 -1

file changed

src/bin/koji-ssl-admin

koji-tools

Source Code

#29 koji-ssl-admin: pkcs12 password must be bytes Merged 5 years ago by tkopecek. Opened 5 years ago by ktdreyer. ktdreyer/koji-tools ssl-admin-password-bytes into master

Metadata

Changes Summary 1

#29 koji-ssl-admin: pkcs12 password must be bytes

Merged 5 years ago by tkopecek. Opened 5 years ago by ktdreyer.

ktdreyer/koji-tools ssl-admin-password-bytes into master