PR#40: koji-search-containers: raise when metadata.json download fails - koji-tools

koji-tools

#40 koji-search-containers: raise when metadata.json download fails

Merged 5 years ago by tkopecek. Opened 5 years ago by ktdreyer.

ktdreyer/koji-tools search-containers-check-response into master

koji-search-containers: raise when metadata.json download fails

Ken Dreyer • 5 years ago

9180933

file modified

		`@@ -102,6 +102,7 @@`
		`"""`
		`url = get_metadata_url(profile, build)`
		`response = rsession.get(url)`
		`+ response.raise_for_status()`
		`return response.json()`

ktdreyer commented 5 years ago

Prior to this change, if the Koji packages web server returned an HTTP error for the container build metadata.json file, we would not catch this error. The program might crash later on when parsing response.json(), or elsewhere.

Raise immediately if we get an HTTP error when downloading the metadata.json file. This makes it easier for developers to understand the root cause of a failure in this code.