PR#43: koji-ssl-admin: improve comments for bundle_user_browser_cert() - koji-tools

koji-tools

#43 koji-ssl-admin: improve comments for bundle_user_browser_cert()

Merged 5 years ago by tkopecek. Opened 5 years ago by ktdreyer.

ktdreyer/koji-tools ssl-admin-comments into master

koji-ssl-admin: add docstring for bundle_user_browser_cert()

Ken Dreyer • 5 years ago

84267d3

koji-ssl-admin: remove duplicate comment

Ken Dreyer • 5 years ago

a0e6408

src/bin/koji-ssl-admin

file modified

+5 -2

		`@@ -402,9 +402,12 @@`


		`def bundle_user_browser_cert(crt_path, key_path, ca_crt_path, force):`
		`+ """`
		`+ Combine a user's public .crt file and matching .key file into one file.`
		`+`
		`+ Use the .pkcs12 bundle file to log into Kojiweb.`
		`+ """`
		`pkcs12_path = re.sub(r'\.key$', '_browser_cert.p12', key_path)`
		`- # If this is a user cert, and we have a matching .key file in the same`
		`- # directory, then generate a pkcs12 bundle file with the cert and key.`
		`write_pkcs12(crt_path, key_path, ca_crt_path, pkcs12_path, force)`
		`print('wrote %s for kojiweb - protect this private file' % pkcs12_path)`
		`print('to import %s into browser, the password is "koji"' % pkcs12_path)`

ktdreyer commented 5 years ago

Add a docstring for the bundle_user_browser_cert() method, and remove a comment I accidentally copy-and-pasted from the sign() method that calls this bundle_user_browser_cert() method.