koji-tools

Clone
Source Code
GIT

#65 containers: error on incomplete builds
Merged 2 years ago by tkopecek. Opened 2 years ago by ktdreyer.
ktdreyer/koji-tools container-state-complete  into  master

file modified
+2 -2 
@@ -183,12 +183,12 @@ 
 

      session = get_session(args.profile)
 

  

      old_build = session.getBuild(args.old_nvr)
 

-     if not old_build:
 

+     if not old_build or old_build['state'] != koji.BUILD_STATES['COMPLETE']:
 

          help_missing_nvr(args.profile, session, args.old_nvr)
 

          raise SystemExit(1)
 

  

      new_build = session.getBuild(args.new_nvr)
 

-     if not new_build:
 

+     if not new_build or new_build['state'] != koji.BUILD_STATES['COMPLETE']:
 

          help_missing_nvr(args.profile, session, args.new_nvr)
 

          raise SystemExit(1)

file modified
+1 -1 
@@ -171,7 +171,7 @@ 
 

      args = parse_args()
 

      session = get_session(args.profile)
 

      build = session.getBuild(args.nvr)
 

-     if not build:
 

+     if not build or build['state'] != koji.BUILD_STATES['COMPLETE']:
 

          help_missing_nvr(args.profile, session, args.nvr)
 

          raise SystemExit(1)
 

      build_date = build['completion_ts']

If builds are not complete, show a friendly error message instead of requesting metadata.json later and failing.

Commit 57d3029 fixes this pull-request

Pull-Request has been merged by tkopecek
2 years ago

Pull-Request has been merged by tkopecek
2 years ago
Metadata
None
No Tags
Changes Summary 2
+2 -2
file changed
src/bin/koji-diff-containers
+1 -1
file changed
src/bin/koji-search-containers
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.