koji

#1213 uploadFile should raise exception and delete uploaded file with wrong md5sum
Closed: Invalid by mikem. Opened by mfilip.

Closed: Invalid
Reopen Issue

Steps to Reproduce:

uploadFile('/mnt/brew/work/',                   # path
           'test-file.txt',                     # name
           18,                                  # size
           'wronghashb93a1b415878e2632a7c4fc',  # wrong md5sum
           -1,                                  # chunk offset
           'dGVzdCBmaWxlIGNvbnRlbnQK')          # base64 data

Current result:

False 
(file is created anyway)

Expected result:

GenericError: md5sum does't match.
(file is deleted just after md5sum calculation)

Note
The same problem occurred if md5sum is correct but size parameter is wrong.

Closing as notabug. The client expects True/False here. An exception would break retries in the old upload mechanism.

The file should not be deleted simply because one chunk did not upload correctly. The behavior of this call needs to be viewed in context of the uploadWrapper() method in ClientSession.
Edited by mikem

Metadata Update from @mikem:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1213

Please continue any further discussion there.
Metadata
None
None
None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.