Issue #1421: API filterResults returns Fault for API call which not returns list and non exist API call - koji

koji

#1421 API filterResults returns Fault for API call which not returns list and non exist API call

Closed: Fixed Mar 9, 2020 by tkopecek. Opened May 10, 2019 by jcupova.

Steps to Reproduce:

Run filterResults('createTag', tag_name)

Actual result:

Fault: : createTag() did not return a list">

Expected result:

It should be GenericError.

Steps to Reproduce:

Run filterResults('nonExistAPI')

Actual result:

Fault: : 'RootExports' object has no attribute 'nonExistAPI'">

Expected result:

It should be GenericError.

Metadata Update from @tkopecek:
- Custom field Size adjusted to small
- Issue priority set to: Low (was: Normal)

Oct 1, 2019

Metadata Update from @dgregor:
- Issue set to the milestone: 1.21

Jan 2, 2020

tkopecek commented Jan 16, 2020

We want to rise TypeError/AttributeError corresponding to docs. Problem is, that convertFault is ignoring standard exception and can reraise only koji ones. Question is, if we want to improve this behaviour and create koji.TypeError, koji.AttributeError, etc. and a) return these errors from convertFault or b) convert them to standard python exceptions there.

Caveat is, that there may be some code already handling Fault errors and "fixing" this could break them.

@mikem @julian8628 - opinions?

Edited Jan 16, 2020 by tkopecek

mikem commented Feb 20, 2020

Auto-converting anything other than our internal exception classes sounds like a bad idea to me.

mikem commented Feb 20, 2020

A hub call handler should not be deliberately raising TypeError, this is simply not sane.

I'm ok with making this a GenericError as Jana suggests (and changing the docstring correspondingly). At some point, it would be nice to refactor our exception hierarchy so that we don't just raise GenericError all the time, but for now most of the code does.

tkopecek commented Feb 21, 2020

PR #2027

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Feb 28, 2020

Metadata Update from @jcupova:
- Issue untagged with: testing-ready

Mar 4, 2020

tkopecek commented Mar 4, 2020

/missing second case/

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Mar 5, 2020

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Mar 9, 2020