koji

#1487 Deprecate md5/sha1 constructors
Closed: Fixed by mikem. Opened by tkopecek.

Closed: Fixed
Reopen Issue

We've these in koji/util.py, but the reason was, that older python needn't to have hashlib. It is no more the case in any of supported versions. Let's deprecate it.

Metadata Update from @tkopecek:
- Custom field Size adjusted to small

Don't deprecate them. Just get rid of them.

@ngompa There still can be some plugin out in the wilderness, so it is not that harmful to wait a two releases before final removal.

PR #1490
Edited by tkopecek

...and filed #1491 for final removal.

Metadata Update from @tkopecek:
- Issue assigned to tkopecek

@ngompa There still can be some plugin out in the wilderness, so it is not that harmful to wait a two releases before final removal.

Frankly, I'm not terribly sympathetic. One release already takes a long time to get cut anyway.

Deprecation is pretty light. We could deprecate in 1.18 and remove in 1.19.

But I agree with @tkopecek , it's a small amount of code, so not really harmful to keep it a little while longer.

Commit d85be645 fixes this issue

Commit dfbe3222 fixes this issue

Metadata Update from @mfilip:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1487

Please continue any further discussion there.
Metadata

deprecation testing-done

None
None
Low
small
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.