koji

#1605 cg_init_build() allows setting volume/etc
Closed: Dropped by dgregor. Opened by mikem.

Closed: Dropped
Reopen Issue

This came up in review of PR #1602.

BTW, should we forbid user to set volume or in cg_init_build?
it might confuse people, because volume policy will finally override it after CGimport is finished.

The call can also set values like source, task_id, and extra, which was not necessarily intended, but may not be a problem either.

Opening this for discussion.

It seems slightly wrong to me to have some of these values set from data outside the metadata itself.

On the other hand, this is just a placeholder entry and these values are all overridden at CGImport time.

On the third hand :raised_hand: :raised_hand: :raised_hand:, that allows for potentially meaningful data to be replaced. If the value of extra prior to import matters, then it seems like it's important enough to preserve. If it doesn't matter, then maybe it's best not allow it to be set at that point.

Metadata Update from @mikem:
- Custom field Size adjusted to None

I think, that there should be no expectation, that any data will be alive after final import. It should be allowed to rewrite anything. If CG needs some data to preserve, it should be its responsibility.

I'm not sure about task_id and similar fields. It could be used to "hack" the data. E.g. listBuilds(taskID=xyz) can return something which is not true and it will be hidden after final import without trace. On the other hand, we still trust CGs on very high level, so they can do similar things in other places.

I think at least that we don't have to make a change for 1.18. If this is a problem, we can solve it later.

Metadata Update from @mikem:
- Custom field Size adjusted to small (was: None)
- Issue set to the milestone: 1.19 (was: 1.18)

Metadata Update from @dgregor:
- Issue set to the milestone: 1.20 (was: 1.19)

Time to drop this one, or do we want to do something here? @mikem ?

Dropping this as it hasn't turned out to be a problem.

Metadata Update from @dgregor:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

Metadata Update from @dgregor:
- Issue set to the milestone: None (was: 1.20)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1605

Please continue any further discussion there.
Metadata
None

discussion

None
None
Low
small
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.