koji

#1786 koji cli should probably error if there is no config at all
Closed: Fixed by tkopecek. Opened by mikem.

Closed: Fixed
Reopen Issue

This is a follow up to PR #1767

The current code in read_config() has this check:

    if config.sections() and not got_conf:
        raise ConfigurationError("no configuration for profile name: %s" % profile_name)

The first part of the check is False when there is no config at all (all config files missing or empty), which allows the command to proceed with only the hard coded defaults. At one point in our history this might have been sensible, but it doesn't seem correct now.

Leaving this open for discussion if anyone has different opinions.

Metadata Update from @mikem:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.20
- Issue tagged with: discussion

+1. The default doesn't make much sense right now, unless some people are using it for their dev environment.
Edited by julian8628

candidate PR #1787

:thumbsup: to raising an exception in this case.

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Commit 8f0efe89 fixes this issue

Commit f7f1c65b fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1786

Please continue any further discussion there.
Metadata
None

discussion testing-done

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.